Repository navigation
option to disable /models /routes routes - #1135
Conversation
dd7f5bb to
c9481da
Compare
|
Condensed into a single commit and added the functionality to limit the |
There was a problem hiding this comment.
Please use ^1.0.0 so that we are automatically picking up new compatible versions in the future.
|
@greaterweb Good job, thank you for the pull request. Please address my comments above. |
|
Thank you for the feedback. I will correct these items and update the PR. |
1c80abd to
57e8e6f
Compare
|
Updates implemented as suggested by @bajtos, rewrote the history to keep it clean as one small commit. I can't see why the Merged build is failing unfortunately. I'm getting prompted me to authorize StrongLoop Jenkins with permissions to read/write for all of my public and private repos, not sure I want to do that :-) Should any additional updates be required, please feel free to let me know. |
|
The code LGTM, thank you. The tests are failing because |
|
@greaterweb #1140 has been landed, could you please rebase your patch on top of the current master? In case you haven't done this before, here is one of the many ways: |
|
Sounds good, I'll get it ready. |
2327df2 to
94b5b6c
Compare
Setting legacyExplorer to false in the loopback config will disable the routes /routes and /models made available in loopback.rest. The deprecate module has been added to the project with a reference added for the legacyExplorer option as it is no longer required by loopback-explorer. Tests added to validate functionality of disabled and enabled legacy explorer routes.
94b5b6c to
1818a8f
Compare
|
Ok, should be good to go. Test are working ok locally but seem to be failing for CI. Made a small update to remove my addition of If you can see anything on my end that needs to be updated to fix the CI tests, please let me know. |
|
For posterity, Travis CI is failing due to PhantomJS timeouts. Our Jenkins CI passed on 4 slaves out of 6, the remaining two slaves ran into race condition when checking out the code from git. It's a know problem of Jenkins which we did not managed to fix yet. |
ability to disalbe /models /routes routes
|
Landed, thank you for the contribution! |
PR for #1134
WIP though feedback ok for existing work.
Suggested Functionality
Also:
/models/routescan be disabled